<html>
<head><meta charset="utf-8"><title>why are tests ignored · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/why.20are.20tests.20ignored.html">why are tests ignored</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="134609291"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/why%20are%20tests%20ignored/near/134609291" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Tom Tromey <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/why.20are.20tests.20ignored.html#134609291">(Sep 25 2018 at 16:25)</a>:</h4>
<p>Is there any way to find out why a test is ignored?  I've built rustc against 3 versions of llvm, and the debuginfo tests are ignored for the llvm5 and llvm6 builds, but not for the build against src/llvm.</p>



<a name="134609486"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/why%20are%20tests%20ignored/near/134609486" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/why.20are.20tests.20ignored.html#134609486">(Sep 25 2018 at 16:28)</a>:</h4>
<p>ignored by <code>x.py test</code>?</p>



<a name="134609507"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/why%20are%20tests%20ignored/near/134609507" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Tom Tromey <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/why.20are.20tests.20ignored.html#134609507">(Sep 25 2018 at 16:28)</a>:</h4>
<p>Yes.  Also in both config.toml files I have <code>codegen-tests = true</code></p>



<a name="134609822"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/why%20are%20tests%20ignored/near/134609822" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/why.20are.20tests.20ignored.html#134609822">(Sep 25 2018 at 16:34)</a>:</h4>
<p><span class="user-mention" data-user-id="129503">@Tom Tromey</span> hmm. I mean you can read into the code a bit</p>



<a name="134609846"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/why%20are%20tests%20ignored/near/134609846" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Tom Tromey <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/why.20are.20tests.20ignored.html#134609846">(Sep 25 2018 at 16:34)</a>:</h4>
<p>eddyb thinks it is because the test infra remembers the results</p>



<a name="134609904"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/why%20are%20tests%20ignored/near/134609904" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/why.20are.20tests.20ignored.html#134609904">(Sep 25 2018 at 16:35)</a>:</h4>
<p>plausible</p>



<a name="134609910"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/why%20are%20tests%20ignored/near/134609910" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/why.20are.20tests.20ignored.html#134609910">(Sep 25 2018 at 16:35)</a>:</h4>
<p>you could test by removing the <code>stamp</code> files</p>



<a name="134610023"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/why%20are%20tests%20ignored/near/134610023" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Tom Tromey <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/why.20are.20tests.20ignored.html#134610023">(Sep 25 2018 at 16:37)</a>:</h4>
<p>that worked, thanks.</p>



<a name="134610114"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/why%20are%20tests%20ignored/near/134610114" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/why.20are.20tests.20ignored.html#134610114">(Sep 25 2018 at 16:38)</a>:</h4>
<p>we should probably adjust the logic</p>



<a name="134610122"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/why%20are%20tests%20ignored/near/134610122" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/why.20are.20tests.20ignored.html#134610122">(Sep 25 2018 at 16:38)</a>:</h4>
<p>to include info about the llvm build being used or whatever</p>



<a name="134610130"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/why%20are%20tests%20ignored/near/134610130" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/why.20are.20tests.20ignored.html#134610130">(Sep 25 2018 at 16:38)</a>:</h4>
<p>the stamp files are great except when they don't consider all the variables</p>



<a name="134610176"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/why%20are%20tests%20ignored/near/134610176" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Tom Tromey <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/why.20are.20tests.20ignored.html#134610176">(Sep 25 2018 at 16:39)</a>:</h4>
<p>The debuginfo tests in particular are exposed to PATH changes - I have to test this patch against different versions of gdb etc.</p>



<a name="134610226"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/why%20are%20tests%20ignored/near/134610226" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Tom Tromey <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/why.20are.20tests.20ignored.html#134610226">(Sep 25 2018 at 16:40)</a>:</h4>
<p>Caching here just doesn't seem great to me.</p>



<a name="134610388"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/why%20are%20tests%20ignored/near/134610388" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/why.20are.20tests.20ignored.html#134610388">(Sep 25 2018 at 16:42)</a>:</h4>
<p>I forget where that logic lives</p>



<a name="134613342"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/why%20are%20tests%20ignored/near/134613342" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Tom Tromey <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/why.20are.20tests.20ignored.html#134613342">(Sep 25 2018 at 17:25)</a>:</h4>
<p>I found it, but it's difficult to have the stamp hash incorporate the path, because the hash check is done before the test is created and so can only depend on the overall config.</p>



<a name="134615397"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/why%20are%20tests%20ignored/near/134615397" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/why.20are.20tests.20ignored.html#134615397">(Sep 25 2018 at 17:59)</a>:</h4>
<p>disabling those for the debuginfo tests might be ok</p>



<a name="134615406"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/why%20are%20tests%20ignored/near/134615406" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/why.20are.20tests.20ignored.html#134615406">(Sep 25 2018 at 17:59)</a>:</h4>
<p>if we can't incorporate all the dependencies</p>



<a name="134616463"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/why%20are%20tests%20ignored/near/134616463" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Tom Tromey <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/why.20are.20tests.20ignored.html#134616463">(Sep 25 2018 at 18:15)</a>:</h4>
<p>actually I think I'm mistaken and maybe it can be done - going to try</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>